Skip to content

fix(controller-utils): update debug PD-5248 #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(controller-utils): update debug PD-5248 #2024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/controller-utils/src/persistence.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export const compact = (arr) => {
if (Array.isArray(arr)) {
return arr.filter((v) => v !== null && v !== undefined);
}

return arr;
};

Expand All @@ -28,7 +29,7 @@ export const getShuffledChoices = (choices, session, updateSession, choiceKey) =
warn("unable to save shuffled choices because there's no session.");
resolve(undefined);
} else if (!isEmpty(currentShuffled)) {
debug('use shuffledValues to sort the choices...', session.data?.shuffledValues);
debug('use shuffledValues to sort the choices...', currentShuffled);
resolve(compact(currentShuffled.map((v) => choices.find((c) => c[choiceKey] === v))));
} else {
const shuffledChoices = shuffle(choices);
Expand All @@ -39,6 +40,7 @@ export const getShuffledChoices = (choices, session, updateSession, choiceKey) =
const shuffledValues = compact(shuffledChoices.map((c) => c[choiceKey]));
log('try to save shuffledValues to session...', shuffledValues);
log('call updateSession... ', session.id, session.element);

if (isEmpty(shuffledValues)) {
error(
`shuffledValues is an empty array? - refusing to call updateSession: shuffledChoices: ${JSON.stringify(
Expand All @@ -58,6 +60,7 @@ export const getShuffledChoices = (choices, session, updateSession, choiceKey) =
} else {
warn('unable to save shuffled choices, shuffle will happen every time.');
}

//save this shuffle to the session for later retrieval
resolve(shuffledChoices);
}
Expand Down