Skip to content

Conversation

@joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Oct 27, 2025

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Ruihao Chen <joechenrh@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2025
@tiprow
Copy link

tiprow bot commented Oct 27, 2025

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joechenrh joechenrh changed the title [DNM] ddl,tables: test branch for modify column [DNM]ddl,tables: test branch for modify column Oct 27, 2025
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.1039%. Comparing base (a84aea0) to head (1347d54).
⚠️ Report is 6 commits behind head on master.

⚠️ Current head 1347d54 differs from pull request most recent head 7e217af

Please upload reports for the commit 7e217af to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64127        +/-   ##
================================================
+ Coverage   72.7425%   74.1039%   +1.3614%     
================================================
  Files          1854       1876        +22     
  Lines        501719     509741      +8022     
================================================
+ Hits         364963     377738     +12775     
+ Misses       114581     108342      -6239     
- Partials      22175      23661      +1486     
Flag Coverage Δ
integration 45.8127% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 61.9448% <ø> (+15.5596%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Ruihao Chen <joechenrh@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tangenta for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joechenrh joechenrh changed the title [DNM]ddl,tables: test branch for modify column [DNM] ddl, tables: test branch for modify column Oct 27, 2025
Signed-off-by: Ruihao Chen <joechenrh@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 27, 2025

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 27, 2025

@joechenrh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-mysql-client-test-next-gen 7e217af link true /test pull-mysql-client-test-next-gen
idc-jenkins-ci-tidb/check_dev 7e217af link true /test check-dev
pull-mysql-client-test 7e217af link true /test pull-mysql-client-test
pull-unit-test-next-gen 7e217af link true /test pull-unit-test-next-gen
pull-integration-e2e-test 7e217af link true /test pull-integration-e2e-test
idc-jenkins-ci-tidb/mysql-test 7e217af link true /test mysql-test
pull-unit-test-ddlv1 7e217af link true /test pull-unit-test-ddlv1
idc-jenkins-ci-tidb/unit-test 7e217af link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 7e217af link true /test check-dev2
pull-build-next-gen 7e217af link true /test pull-build-next-gen
idc-jenkins-ci-tidb/build 7e217af link true /test build
pull-integration-realcluster-test-next-gen 7e217af link true /test pull-integration-realcluster-test-next-gen
pull-br-integration-test 7e217af link true /test pull-br-integration-test
pull-lightning-integration-test 7e217af link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant