Move file rows to actually be upload rows. #1349
Merged
+48
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
file-upload-table
branch
from
a611a28 to
558df0a
Compare
corylown
reviewed
Oct 28, 2025
| <%= render 'uploads/file_table' do %> | ||
| <%= render 'uploads/file_rows', upload: @upload %> | ||
| <%= render 'uploads/table' do %> | ||
| <%= render 'uploads/row', upload: @upload %> |
There was a problem hiding this comment.
I wonder if we're going to end up wanting to keep file_rows around so the upload show view lists out all the files individually. But considering how most contributors are using POD I'm not sure we care right now.
corylown
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should set us up for #1342, which should make #1323 more efficient (as a database query?).