(CAT-2385) Puppetcore update #1646
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamshinde360
force-pushed
the
CAT-2385
branch
2 times, most recently
from
940e023 to
d8dd30d
Compare
|
@shubhamshinde360 can you please rebase? The unit tests were fixed in #1647 |
bastelfreak
reviewed
Sep 30, 2025
.fixtures.yml
Outdated
| systemd: "https://github.com/voxpupuli/puppet-systemd.git" | ||
| systemd: | ||
| repo: "https://github.com/voxpupuli/puppet-systemd.git" | ||
| ref: 8.3.1 |
There was a problem hiding this comment.
you don't need to pin the module
bastelfreak
reviewed
Sep 30, 2025
.fixtures.yml
Outdated
| apt: "https://github.com/puppetlabs/puppetlabs-apt.git" | ||
| apt: | ||
| repo: 'https://github.com/puppetlabs/puppetlabs-apt.git' | ||
| ref: v10.0.1 |
There was a problem hiding this comment.
you don't need to pin the module
bastelfreak
reviewed
Sep 30, 2025
| gem "json", '= 2.1.0', require: false if Gem::Requirement.create(['>= 2.5.0', '< 2.7.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) | ||
| gem "json", '= 2.3.0', require: false if Gem::Requirement.create(['>= 2.7.0', '< 3.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) | ||
| gem "json", '= 2.5.1', require: false if Gem::Requirement.create(['>= 3.0.0', '< 3.0.5']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) | ||
| gem "json", '= 2.6.1', require: false if Gem::Requirement.create(['>= 3.1.0', '< 3.1.3']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) |
There was a problem hiding this comment.
you do lint for ruby 3.1 as a target, so everything will fail on ruby 3.0 anyways and the condition isn't required?
bastelfreak
reviewed
Sep 30, 2025
| gem "json", '= 2.6.3', require: false if Gem::Requirement.create(['>= 3.2.0', '< 4.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) | ||
| gem "racc", '~> 1.4.0', require: false if Gem::Requirement.create(['>= 2.7.0', '< 3.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) | ||
| gem "deep_merge", '~> 1.2.2', require: false | ||
| gem "voxpupuli-puppet-lint-plugins", '~> 5.0', require: false |
There was a problem hiding this comment.
voxpupuli-puppet-lint-plugins, facterdb and rspec-puppet-facts are quite outdated, even after your changes. Are there plans to switch to newer versions?
shubhamshinde360
force-pushed
the
CAT-2385
branch
from
d8dd30d to
eba9dd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Puppetcore update
Checklist
puppet apply)