Skip to content

Conversation

@zaplapl
Copy link
Contributor

@zaplapl zaplapl commented Nov 2, 2025

closes #13865 by duplicating self._outrep_summary(rep) invocation during summary_failures_combined

considered refactoring into something like:

        for rep in reports:
            self._outrep_summary(rep)
                if style == "line":
                        line = self._getcrashline(rep)
                        self.write_line(line)
                else:
                        msg = self._getfailureheadline(rep)
                        self.write_sep("_", msg, red=True, bold=True)
                        self._handle_teardown_sections(rep.nodeid)

to avoid committing too hard to the branching logic in the code

but submitting this commit instead since it has fewer side-effects

zaplapl and others added 5 commits November 2, 2025 18:57
Assert output includes `- Captured stdout call -`
add outrep summary to report when the formatting style is set to `line`
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Nov 2, 2025
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zaplapl for the PR, please take a look at my comments.

zaplapl and others added 3 commits November 3, 2025 18:59
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nicoddemus nicoddemus enabled auto-merge (squash) November 3, 2025 22:25
@nicoddemus nicoddemus merged commit 76910ca into pytest-dev:main Nov 3, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--show-capture not working when --tb=line

2 participants