Inline the validate() function #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_EventBundle uses a lot of dynamic python features to save on some duplication, but it slows things down, and will also make it much harder to add static typing. Since these types are now pretty stable, it seems not worth it. On the bench/ micro-benchmark: Before: 9322.6 requests/sec After : 10544.6 requests/sec
It somewhat obscures the control flow and adds some non-trivial overhead. Inline it in favor of the direct match/if combination. On the bench/ microbenchmark: Before: 10700.2 requests/sec After : 11334.0 requests/sec
|
I also prefer this approach, however as it more of a preference question I'll wait for more views. |
From the last commit, that seems okay as a trade-off, yup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #118, please look at the last commit only. (Sorry for the jungle of PRs, I can rebase them whichever way).
It somewhat obscures the control flow and adds some non-trivial overhead.
Inline it in favor of the direct match/if combination.
On the bench/ microbenchmark: