-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix geopandas on python 3.14 #2191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hansthen
wants to merge
7
commits into
python-visualization:main
from
hansthen:fix_geopandas_on_python_3.14
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d2fd46c
Close issue_2165 (#2166)
hansthen 338c44a
Try to fix geopandas test run
hansthen 086b10c
No 3.14 yet
hansthen 3f6abea
Try something else
hansthen 7ab1e36
Will sudo work in a runner?
hansthen 7c911e7
Remove libgdal-doc
hansthen 09853f2
Try another
hansthen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a look later but we should not need any of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue here is that we're pulling geopandas dependencies from PyPI rather than conda-forge and that pyogrio does not have wheels for 3.14 yet on PyPI.
This fix is temporary as once the wheels will be there, we will not need to build from source. So the easier solution for a temp fix would imho be pinning python on l.31 to 3.13. Another option is to install geopandas deps from conda-forge but this workflow will work with that one line change now and in the original state as soon as new pyogrio lands.