GH-140590: Fix setstate for functools.partial C-module #140671

sergey-miryanov · 2025-10-27T13:26:21Z

There is a missing check for the namespace.

Issue: SEGV functools _Py_dict_lookup #140590

sergey-miryanov · 2025-10-27T13:31:19Z

It is ready for review, could you please take a look.

sergey-miryanov · 2025-10-27T13:32:11Z

Python version has this check already, but C version missing it:

        if (not callable(func) or not isinstance(args, tuple) or
           (kwds is not None and not isinstance(kwds, dict)) or
           (namespace is not None and not isinstance(namespace, dict))):
            raise TypeError("invalid partial state")

Modules/_functoolsmodule.c

efimov-mikhail

LGTM, I have just one comment on the style.

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>

miss-islington-app · 2025-10-28T09:28:36Z

Thanks @sergey-miryanov for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

…H-140671) (cherry picked from commit d26686a) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com> Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>

bedevere-app · 2025-10-28T09:29:02Z

GH-140698 is a backport of this pull request to the 3.14 branch.

bedevere-app · 2025-10-28T09:29:07Z

GH-140699 is a backport of this pull request to the 3.13 branch.

) (#140699) GH-140590: Fix setstate for functools.partial C-module (GH-140671) (cherry picked from commit d26686a) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com> Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>

) (#140698) GH-140590: Fix setstate for functools.partial C-module (GH-140671) (cherry picked from commit d26686a) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com> Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>

bedevere-bot · 2025-10-28T13:20:17Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.13 (tier-2) has failed when building commit bec053c.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1404/builds/1360) and take a look at the build logs.
Check if the failure is related to this commit (bec053c) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1404/builds/1360

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/contextlib.py", line 136, in __enter__
    def __enter__(self):
ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 56972), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 56980), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/contextlib.py", line 136, in __enter__
    def __enter__(self):
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 56980), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 56986), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/contextlib.py", line 136, in __enter__
    def __enter__(self):
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 56986), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 56988), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 56988), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 56990), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 56990), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 57016), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 57018), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 57018), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 56968), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 56970), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 56970), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 57029), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 57031), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=10, family=2, type=1, proto=6, laddr=('192.168.0.101', 57031), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 56982), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 56984), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 56984), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 57023), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 57025), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 57025), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 845, in gc_collect
    gc.collect()
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 57040), raddr=('68.183.26.59', 21)>


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/socket_helper.py", line 225, in transient_internet
    captured_errnos = [getattr(errno, name, num)
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 57020), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 57027), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/socket_helper.py", line 225, in transient_internet
    captured_errnos = [getattr(errno, name, num)
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 57027), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 57033), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/socket_helper.py", line 225, in transient_internet
    captured_errnos = [getattr(errno, name, num)
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('192.168.0.101', 57033), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 57036), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 57036), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 57038), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 57038), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/__init__.py", line 845, in gc_collect
    gc.collect()
ResourceWarning: unclosed <socket.socket fd=6, family=2, type=1, proto=6, laddr=('192.168.0.101', 56992), raddr=('68.183.26.59', 21)>


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=7, family=2, type=1, proto=6, laddr=('192.168.0.101', 56976), raddr=('68.183.26.59', 21)>
Warning -- Unraisable exception
Exception ignored in: <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 56978), raddr=('68.183.26.59', 21)>
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.pablogsal-macos-m1.macos-with-brew/build/Lib/socket.py", line 790, in close
    self._sock = None
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('192.168.0.101', 56978), raddr=('68.183.26.59', 21)>
skipped "Resource 'ftp://www.pythontest.net/' is not available"

Fix setstate for functools.partial C-module

794cf18

bedevere-app bot mentioned this pull request Oct 27, 2025

SEGV functools _Py_dict_lookup #140590

Closed

Add news

1936299

sergey-miryanov added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 27, 2025

sergey-miryanov marked this pull request as ready for review October 27, 2025 13:30

sergey-miryanov requested a review from rhettinger as a code owner October 27, 2025 13:30

bedevere-app bot added the awaiting review label Oct 27, 2025

sergey-miryanov requested a review from efimov-mikhail October 27, 2025 13:31

efimov-mikhail reviewed Oct 27, 2025

View reviewed changes

Modules/_functoolsmodule.c Outdated Show resolved Hide resolved

efimov-mikhail reviewed Oct 27, 2025

View reviewed changes

Update Modules/_functoolsmodule.c

2fd2fca

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>

efimov-mikhail approved these changes Oct 27, 2025

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels Oct 27, 2025

kumaraditya303 approved these changes Oct 27, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels Oct 27, 2025

encukou merged commit d26686a into python:main Oct 28, 2025
53 checks passed

bedevere-app bot removed the awaiting merge label Oct 28, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 28, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Uh oh!

GH-140590: Fix setstate for functools.partial C-module #140671

GH-140590: Fix setstate for functools.partial C-module #140671

sergey-miryanov commented Oct 27, 2025 •

edited by bedevere-app bot

Loading

Uh oh!

sergey-miryanov commented Oct 27, 2025

Uh oh!

sergey-miryanov commented Oct 27, 2025

Uh oh!

Uh oh!

efimov-mikhail left a comment •

edited

Loading

Uh oh!

Uh oh!

miss-islington-app bot commented Oct 28, 2025

Uh oh!

bedevere-app bot commented Oct 28, 2025

Uh oh!

bedevere-app bot commented Oct 28, 2025

Uh oh!

bedevere-bot commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

GH-140590: Fix setstate for functools.partial C-module #140671

GH-140590: Fix setstate for functools.partial C-module #140671

Conversation

sergey-miryanov commented Oct 27, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sergey-miryanov commented Oct 27, 2025

Uh oh!

sergey-miryanov commented Oct 27, 2025

Uh oh!

Uh oh!

efimov-mikhail left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Oct 28, 2025

Uh oh!

bedevere-app bot commented Oct 28, 2025

Uh oh!

bedevere-app bot commented Oct 28, 2025

Uh oh!

bedevere-bot commented Oct 28, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sergey-miryanov commented Oct 27, 2025 •

edited by bedevere-app bot

Loading

efimov-mikhail left a comment •

edited

Loading