gh-140381: Increase slow_fibonacci call frequency in test_profiling #140673
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140381
Problem
Tests asserting "slow_fibonacci" in test_profiling were flaky on slower architectures (i686/s390x) because the function wasn't called frequently enough for the profiler to reliably capture it.
Solution
Changed slow_fibonacci to run every 2nd iteration instead of every 5th iteration, increasing its call frequency from 20% to 50% of iterations.
Testing
This should resolve the flaky test failures on i686/s390x builds.
test_profilingflaky fail on i686/s390x builds in Fedora Linux #140381