mxtensor: make scale shape match qdata #3198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
vkuzo
added a commit
that referenced
this pull request
Oct 17, 2025
Summary: Given `qdata` shape M, K, makes `scale` shape be M, K // block_size This will be important to keep the logic sane as we add pre-swizzling in a future PR. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d8d4e78 ghstack-comment-id: 3413479441 Pull-Request: #3198
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3198
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This was referenced Oct 17, 2025
vkuzo
added
the
topic: improvement
vkuzo
added a commit
that referenced
this pull request
Oct 17, 2025
Summary: Given `qdata` shape M, K, makes `scale` shape be M, K // block_size This will be important to keep the logic sane as we add pre-swizzling in a future PR. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4d07c2b ghstack-comment-id: 3413479441 Pull-Request: #3198
drisspg
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Given
qdatashape M, K, makesscaleshape be M, K // block_sizeThis will be important to keep the logic sane as we add pre-swizzling
in a future PR.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: