This repository was archived by the owner on Nov 16, 2018. It is now read-only.
Fix/react 16 update #207
Open
Fix/react 16 update #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he bottom and fix related look and feel
Feature support on blur
Added support for custom ref for input field
…to the basic example.
Support for minDate and maxDate for months and years calendar.
BARRY-78 adding ability to pass displayformat for datetime.
Initialise the value to dateTime even with defaultText set
Fixed readme on point the library locally
…the date to be EMPTY. So after the fix, when you set the dateTime prop to be null/empty string, the datePicker field will show empty value ( with placeholder text).But if you set the dateTime=undefined, it will show today’s date.
…e through navigation bar, then come back, the panel for showing the days will be NaN, user could not select any date again
TITAN-335: do not format inputValue when onChange
…ke an existing Moment instance as an alternative to a string. This means that it can be used in situations where you need to keep all your Moment instances in UTC mode. A string may still be provided, and in that case there should be no change in behaviour.
…alue Accept an existing Moment as the initial value
|
Someone going to merge this PR? |
|
no, there is a pretty big notice on the front page in case you missed it: https://github.com/quri/react-bootstrap-datetimepicker#%EF%B8%8F-deprecated-react-bootstrap-datetimepicker |
|
It wouldn't be a bad idea to re-publish the package with the deprecation notice, the NPM page doesn't hint at it being deprecated and 27K downloads/month suggest people really are missing the message. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to a split in the latest React framework. In React > 15.5 the "PropTypes" library has been broken out of the core framework. In the latest react version 16.0 this means that PropTypes needs to be explicitly imported.
15.5
import React from 'react'
React.PropTypes.func.isRequired
16.0
import React from 'react'
import PropTypes from 'prop-types'
PropTypes.func.isRequired