Skip to content

Conversation

@hcirellu
Copy link

For #142
The example in issue #142 now works correctly.
I also fixed the behaviour that the warning is also shown in the case of range(NA_integer64_, na.rm=TRUE).
The same is applied to min.integer64 and max.integer64.

@MichaelChirico
Copy link
Collaborator

Thanks! Please add regresion tests

@hcirellu
Copy link
Author

Regression tests added and reverted to =.

@hcirellu
Copy link
Author

Is there anything more to do or can it be merged?

@MichaelChirico
Copy link
Collaborator

Is there anything more to do or can it be merged?

I just need to find some time, hopefully this weekend.

Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the extra round of review. I tried making these edits directly myself but because your PR is from your main branch, I am unable to do so (or otherwise, you didn't grant me access to edit your fork)

@hcirellu
Copy link
Author

hcirellu commented Oct 30, 2025

Sorry for the extra round of review. I tried making these edits directly myself but because your PR is from your main branch, I am unable to do so (or otherwise, you didn't grant me access to edit your fork)

I thought I allowed it. I'll check.
I added you as collaborator. I hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants