-
Notifications
You must be signed in to change notification settings - Fork 12
fixed max(), min(), range() for multiple inputs if one is non-finite #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks! Please add regresion tests |
|
Regression tests added and reverted to |
|
Is there anything more to do or can it be merged? |
I just need to find some time, hopefully this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the extra round of review. I tried making these edits directly myself but because your PR is from your main branch, I am unable to do so (or otherwise, you didn't grant me access to edit your fork)
I thought I allowed it. I'll check. |
# Conflicts: # tests/testthat/test-integer64.R
For #142
The example in issue #142 now works correctly.
I also fixed the behaviour that the warning is also shown in the case of range(NA_integer64_, na.rm=TRUE).
The same is applied to min.integer64 and max.integer64.