Skip to content

Conversation

@llimllib
Copy link

@llimllib llimllib commented Oct 17, 2025

🚥 Resolves ISSUE_ID

🧰 Changes

  • get the tests passing locally
    • I'm going to defer this. The tests aren't passing locally because they're reading my global git config, I think, so I'm going to rely on CI for now
  • update the test action with a node version matrix
  • get the tests running on macos newer than 13
    • there's a single test that fails, consistently, on macos > 13
  • add tests to the publish job
    • we don't want to publish versions that don't pass the tests
    • gonna add this in the future, but trusting the tests in CI for now. I remvoed it because it was too much setup in the cross-compile jobs to fit comfortably in this PR
  • update the publish job to include node 22 prebuilds
    • we're gonna have super fat binaries until we can get an optionalDependencies-style setup going
  • run linux-arm tests on PRs
  • fix the issue uncovered by running the linux-arm tests
  • update version number

The patch in this commit resolves the build issue noted in nodegit#2023 by applying a patch to zlib, which is a little gross but gets us building at least

@llimllib llimllib changed the title node 22 feat: support node 22 Oct 17, 2025
@llimllib llimllib merged commit 464ce13 into master Oct 21, 2025
23 of 25 checks passed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@@ -1,2 +1 @@
node_modules
test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exclude node_modules but allow test? Are we running tests in the Docker container?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • node_modules is excluded because the docker container may have a different arch so native builds will not work
  • test was excluded to speed up cross-compilation but:
    • it's tiny so kind of useless
    • I want to run the tests on cross-compiles before releasing. I actually had it in this PR but it was too much work so I pushed it off to the future

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that it would be accepted in a timely manner but should this get upstreamed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment on their issue tracker, I'm not gonna bother with a PR because the maintainer doesn't seem to accept them

(If you're the maintainer reading this though, hmu I'd be happy to PR a fix with you)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants