Skip to content

Conversation

@12ya
Copy link
Contributor

@12ya 12ya commented Oct 24, 2025

… use fmt.Fprintf for buffers

Replaced buf.WriteString(fmt.Sprintf(...)) with fmt.Fprintf or fmt.Fprint in test helper functions for improved clarity and efficiency. This change affects push notification and RESP3 test utilities.

… use fmt.Fprintf for buffers

Replaced buf.WriteString(fmt.Sprintf(...)) with fmt.Fprintf or fmt.Fprint in test helper functions for improved clarity and efficiency. This change affects push notification and RESP3 test utilities.
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@12ya thank you for your contribution. left couple of comments for things that should be addressed. lets keep this consistent if we decide to use fmt.Fprint instead of buf.WriteString

@12ya
Copy link
Contributor Author

12ya commented Oct 24, 2025

@12ya thank you for your contribution. left couple of comments for things that should be addressed. lets keep this consistent if we decide to use fmt.Fprint instead of buf.WriteString

hey @ndyakov, i agree - replaced everywhere for consistency

@12ya 12ya requested a review from ndyakov October 24, 2025 22:37
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ndyakov ndyakov merged commit 9c77386 into redis:master Oct 28, 2025
23 checks passed
@12ya 12ya deleted the patch-3 branch October 28, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants