LangCache integration cleanup #418
Open
+183
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrookins
force-pushed
the
rename-langcache-wrapper
branch
from
ff984d0 to
43ad22e
Compare
The name "LangCacheWrapper" just doesn't hit as deep. Also, it doesn't follow the same pattern as "SemanticCache," the Redis-based cache in this library. Seeing "Cache" twice feels better than "Wrapper."
abrookins
force-pushed
the
rename-langcache-wrapper
branch
from
43ad22e to
c9357c3
Compare
abrookins
changed the title
abrookins
force-pushed
the
rename-langcache-wrapper
branch
from
02204b8 to
c7c6c6d
Compare
abrookins
force-pushed
the
rename-langcache-wrapper
branch
from
c7c6c6d to
596dbf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a few changes/fixes to the LangCache integration: