Increase number of tests in stressGraphics #20216
Draft
+11,413
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrows - still need to fix TArrow save primitive
One can easily recognize them and prevent problems when changing test number
Make it as separate commit to simplify git a work. Now only single line in each svg file will be replaced.
Test Results 20 files 20 suites 3d 9h 53m 22s ⏱️ For more details on these failures, see this check. Results for commit 7a66a82. ♻️ This comment has been updated with latest results. |
There are some bug in ROOT graphics handling such canvas, web graphics works as expected!!!
Saving in macro does not work at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many classes and many special draw options were not tested in
stressGraphics:This PR will add all these missing tests.
Needs several iterations because of many platforms
Missing tests also indicating to some problems in saving primitives - like for TArrow or TGraphPolar.
Also reverse axis on TGraph not saved normally - even plain PS output does not work there while web output looks better.
So it will be extra work to fix such problems afterwards.