avm1: Clean up globals #22057
Merged
avm1: Clean up globals #22057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-avm1
Lord-McSweeney
approved these changes
Oct 27, 2025
kjarosh
removed
the
waiting-on-review
This refactor cleans up global definitions and sorts them alphabetically.
Added stubs of missing globals from the documentation.
Some globals are available in later SWF versions.
kjarosh
force-pushed
the
globals-cleanup
branch
from
3aa794e to
7e2b3a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up globals: orders them alphabetically, stubs missing classes, adds required SWF versions, and adds tests for different SWF versions.
Currently the test for swf5 is failing, because we don't support SWF5 globals properly.