Guarantee the binary representation of isize explicitly
#2064
Conversation
rustbot
added
the
S-waiting-on-review
| r[type.numeric.int.size.isize] | ||
| The `isize` type is a signed integer type with the same number of bits as the | ||
| The `isize` type is a signed two's complement integer type with the same number of bits as the |
There was a problem hiding this comment.
I didn't reflow the paragraph as the policy seems to be to not wrap long lines anymore (which I prefer anyway).
traviscross
added
I-lang-nominated
P-lang-drag-1
|
Since we guarantee this for fixed-width signed integers already, it seems clear that we should guarantee it for @rfcbot fcp merge |
|
Team member @tmandry has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
|
@rfcbot reviewed |
traviscross
changed the title
isize explicitlyisize explicitly
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
5 participants
Following the discussion in rust-lang/rust#147960, this adds an explicit guarantee that
isizeis represented with two's complement.This is not intended as a new guarantee, but only as stating what is already mentioned in other places of the reference in the same place as it is for fixed-width integer types:
r? @traviscross