Skip to content

remove invalid workspaceFolder prefix from the zed rust-analyzer config #138085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove invalid workspaceFolder prefix from the zed rust-analyzer config #138085

wants to merge 1 commit into from

Conversation

@cjhowe-us
Copy link

@cjhowe-us cjhowe-us commented Mar 6, 2025

using ${workspaceFolder} causes a lot of incorrect diagnostics on the latest version of zed

@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 6, 2025
@bors
Copy link
Collaborator

bors commented Mar 14, 2025

☔ The latest upstream changes (presumably #138480) made this pull request unmergeable. Please resolve the merge conflicts.

Mark-Simulacrum
Mark-Simulacrum reviewed Mar 15, 2025
View reviewed changes
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Mar 15, 2025

r=me with append + rebase

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2025
@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Apr 13, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot removed the has-merge-commits PR has merge commits, merge with caution. label Apr 13, 2025
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Apr 13, 2025

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Apr 20, 2025

☔ The latest upstream changes (presumably #140053) made this pull request unmergeable. Please resolve the merge conflicts.

@alex-semenyuk
Copy link
Member

alex-semenyuk commented Jul 6, 2025

@cjhowe-us
Thanks for your contribution
Any updates on this PR?

@cjhowe-us cjhowe-us closed this by deleting the head repository Jul 27, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cjhowe-us @rustbot @bors @Mark-Simulacrum @rust-log-analyzer @alex-semenyuk @jieyouxu