Add Drop::pin_drop for pinned drops
#144537
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
frank-king
force-pushed
the
feature/pin-drop
branch
from
362f769 to
1497185
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #146071) made this pull request unmergeable. Please resolve the merge conflicts. |
frank-king
force-pushed
the
feature/pin-drop
branch
from
1497185 to
9b7201c
Compare
frank-king
changed the title
Drop::pin_drop for !Unpin typesDrop::pin_drop for pinned drops
This comment has been minimized.
This comment has been minimized.
frank-king
force-pushed
the
feature/pin-drop
branch
2 times, most recently
from
d6ddfcf to
7b4bb5c
Compare
This comment has been minimized.
This comment has been minimized.
frank-king
force-pushed
the
feature/pin-drop
branch
from
7b4bb5c to
36ca628
Compare
This comment has been minimized.
This comment has been minimized.
frank-king
force-pushed
the
feature/pin-drop
branch
from
36ca628 to
252d6fc
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
The CI failed because |
frank-king
force-pushed
the
feature/pin-drop
branch
from
252d6fc to
02b0b0d
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #146938) made this pull request unmergeable. Please resolve the merge conflicts. |
Dylan-DPC
added
S-experimental
4 tasks
frank-king
force-pushed
the
feature/pin-drop
branch
from
02b0b0d to
7660d88
Compare
This comment has been minimized.
This comment has been minimized.
frank-king
force-pushed
the
feature/pin-drop
branch
from
7660d88 to
33e3124
Compare
This comment has been minimized.
This comment has been minimized.
frank-king
force-pushed
the
feature/pin-drop
branch
2 times, most recently
from
6303109 to
9618d10
Compare
frank-king
force-pushed
the
feature/pin-drop
branch
from
9618d10 to
c3e34d5
Compare
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use |
Collaborator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the
pin_ergonomicsexperiment (the tracking issue is #130494). It allows implementingDropwith a pinnedselfreceiver, which is required for safe pin-projection.Implementations:
dropandpin_dropshould be implemented.droporpin_drop. They should only be called by the drop glue.pin_dropmust and must only be used with types that support pin-projection (i.e. types with#[pin_v2]).fn drop(&pin mut self)and desugars tofn pin_drop(&pin mut self). (Will be in the next PRs)