- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Modify contributor email entries in .mailmap #148204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| rustbot has assigned @Mark-Simulacrum. Use  | 
| 
 @hkBst, thank you so much for keeping track of this. Could you please also add this e-mail address as another entry of mine: software@jacobadam.net, authored as Jacob Adam? I know, it's a bit crazy how many alias entries of mine there are in there, but I guess it's been quite a few years… Sorry for the trouble. Thanks! 🙂 | 
| @jakubadamw Done! | 
        
          
                .mailmap
              
                Outdated
          
        
      | John Kåre Alsaker <john.kare.alsaker@gmail.com> <zoxc32@gmail.com> | ||
| John Talling <inrustwetrust@users.noreply.github.com> | ||
| John Van Enk <vanenkj@gmail.com> | ||
| Jon Gjengset <jongje@amazon.com> <jon@thesquareplanet.com> | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be the other way around please — the canonical is the thesquareplanet one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
Updated email addresses for several contributors in the mailmap.
75ada4a    to
    4877145      
    Compare
  
    | ✌️ @hkBst, you can now approve this pull request! If @nnethercote told you to " | 
| Thanks, @nnethercote, I'm tentatively scheduling this for end of next week, so November 6 or 7. | 
        
          
                .mailmap
              
                Outdated
          
        
      | Wesley Wiser <wwiser@gmail.com> <wesleywiser@microsoft.com> | ||
| whitequark <whitequark@whitequark.org> | ||
| Will Crichton <wcrichto@cs.stanford.edu> <wcrichto@stanford.edu> | ||
| Will Crichton <wcrichto@cs.stanford.edu> <crichton.will@gmail.com> | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crichton.will@gmail.com is a better canonical email for me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
This adds mailmap entries for duplicates I found in https://thanks.rust-lang.org/rust/all-time/
If I added an entry for you and it is not correct, then please let me know! See the comments at the start of https://github.com/rust-lang/thanks/blob/master/mailmap/src/lib.rs for understanding these entries.
After this gets into the repo, the thanks page will be regenerated within a day, and your double entries will be merged.
cc @aochagavia
cc @fasterthanlime
cc @jackh726
cc @jakubadamw
cc @yaahc
cc @jackpot51
cc @jonhoo
cc @marcoieni
cc @onur-ozkan
cc @rylev
cc @willcrichton
cc @yoshuawuyts