Skip to content

Conversation

@hkBst
Copy link
Member

@hkBst hkBst commented Oct 28, 2025

This adds mailmap entries for duplicates I found in https://thanks.rust-lang.org/rust/all-time/

If I added an entry for you and it is not correct, then please let me know! See the comments at the start of https://github.com/rust-lang/thanks/blob/master/mailmap/src/lib.rs for understanding these entries.

After this gets into the repo, the thanks page will be regenerated within a day, and your double entries will be merged.

cc @aochagavia
cc @fasterthanlime
cc @jackh726
cc @jakubadamw
cc @yaahc
cc @jackpot51
cc @jonhoo
cc @marcoieni
cc @onur-ozkan
cc @rylev
cc @willcrichton
cc @yoshuawuyts

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jakubadamw
Copy link
Contributor

jakubadamw commented Oct 28, 2025

cc @jakubadamw

@hkBst, thank you so much for keeping track of this.

Could you please also add this e-mail address as another entry of mine: software@jacobadam.net, authored as Jacob Adam? I know, it's a bit crazy how many alias entries of mine there are in there, but I guess it's been quite a few years… Sorry for the trouble. Thanks! 🙂

@hkBst
Copy link
Member Author

hkBst commented Oct 28, 2025

@jakubadamw Done!

@hkBst hkBst closed this Oct 28, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2025
@hkBst hkBst reopened this Oct 28, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2025
.mailmap Outdated
John Kåre Alsaker <john.kare.alsaker@gmail.com> <zoxc32@gmail.com>
John Talling <inrustwetrust@users.noreply.github.com>
John Van Enk <vanenkj@gmail.com>
Jon Gjengset <jongje@amazon.com> <jon@thesquareplanet.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the other way around please — the canonical is the thesquareplanet one :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Updated email addresses for several contributors in the mailmap.
@nnethercote
Copy link
Contributor

Looks fine to me. @hkBst, feel free to merge once you think enough time has passed for all the mentioned people to have had a look (or a reasonable chance to look).

@bors delegate=hkBst

@bors
Copy link
Collaborator

bors commented Oct 29, 2025

✌️ @hkBst, you can now approve this pull request!

If @nnethercote told you to "r=me" after making some further change, please make that change, then do @bors r=@nnethercote

@hkBst
Copy link
Member Author

hkBst commented Oct 29, 2025

Thanks, @nnethercote, I'm tentatively scheduling this for end of next week, so November 6 or 7.

.mailmap Outdated
Wesley Wiser <wwiser@gmail.com> <wesleywiser@microsoft.com>
whitequark <whitequark@whitequark.org>
Will Crichton <wcrichto@cs.stanford.edu> <wcrichto@stanford.edu>
Will Crichton <wcrichto@cs.stanford.edu> <crichton.will@gmail.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crichton.will@gmail.com is a better canonical email for me, thank you!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@nnethercote nnethercote added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants