Fix deferred cast checks using the wrong body for determining constness #148287
+13
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment was marked as outdated.
This comment was marked as outdated.
fee1-dead
requested changes
Oct 30, 2025
Comment on lines
75
to
76
| // don't hold the borrow to deferred_cast_checks while checking to avoid borrow checker errors | ||
| // when writing to `self.param_env`. |
There was a problem hiding this comment.
This seems to be outdated now; also do we still need to mem::take?
rustbot
added
S-waiting-on-author
oli-obk
force-pushed
the
push-osluqnunqkyl
branch
from
fb2f090 to
8762219
Compare
|
@bors r=fee1-dead rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 31, 2025
Rollup of 3 pull requests Successful merges: - #148165 (Use `mut` less in dataflow analysis) - #148287 (Fix deferred cast checks using the wrong body for determining constness) - #148317 (bootstrap: Extract parts of `bootstrap::core::builder` into a `cli_paths` module) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-introduces #103683
it was lost in 4fec845
deferred checks possibly have more such issues, needs investigation.
r? @fee1-dead