Skip to content

Conversation

@andreivladbrg
Copy link
Member

No description provided.

@smol-ninja

This comment was marked as off-topic.

@andreivladbrg

This comment was marked as off-topic.

Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

Reviewed lockup file only. If you agree, I can add similar changed to Merkle Instant in #402. I may have made some extra changed than the comments below so if you disagree with anything, I will revert them.

@andreivladbrg
Copy link
Member Author

@smol-ninja thanks for the review, i responded to your comments, once we settle on all of them i'll start reviewing the PR you created

@smol-ninja
Copy link
Member

@andreivladbrg instead of reviewing #402, you can pick whatever we agreed on in above comments. It has other changes too which we may not need anymore. There are additional changes which you may like.

Also, I only made changes to Lockup guide and not Merkle Instant so feel free to make similar changes to Merkle Instant guide.

add createWithDurationsLl example
add note about solana wallet path
@andreivladbrg
Copy link
Member Author

so many fails, but we made it 💪

@smol-ninja could you approve it if it looks good now?

Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah 💪

@andreivladbrg andreivladbrg merged commit a128968 into main Oct 29, 2025
1 check passed
@andreivladbrg andreivladbrg deleted the feat/client-integration branch October 29, 2025 15:26
@andreivladbrg andreivladbrg mentioned this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants