-
Notifications
You must be signed in to change notification settings - Fork 20
feat: solana client integration examples #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a049850 to
bf83010
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
3bebbb3 to
ec3817a
Compare
ec3817a to
6ccab3a
Compare
6ccab3a to
c4d4013
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
Reviewed lockup file only. If you agree, I can add similar changed to Merkle Instant in #402. I may have made some extra changed than the comments below so if you disagree with anything, I will revert them.
|
@smol-ninja thanks for the review, i responded to your comments, once we settle on all of them i'll start reviewing the PR you created |
|
@andreivladbrg instead of reviewing #402, you can pick whatever we agreed on in above comments. It has other changes too which we may not need anymore. There are additional changes which you may like. Also, I only made changes to Lockup guide and not Merkle Instant so feel free to make similar changes to Merkle Instant guide. |
add createWithDurationsLl example add note about solana wallet path
90cefca to
0833935
Compare
0833935 to
a965bc8
Compare
c574288 to
606972d
Compare
|
so many fails, but we made it 💪 @smol-ninja could you approve it if it looks good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah 💪
No description provided.