- 
                Notifications
    
You must be signed in to change notification settings  - Fork 252
 
Improvement/cldsrv 724 md search related functional tests #5981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: improvement/CLDSRV-724-versionning-related-functional-tests
Are you sure you want to change the base?
Conversation
          ❌ 56 Tests Failed:
 View the top 3 failed test(s) by shortest run time
 
 
 
 
 
 
 
 
 
 
 
 View the full list of 45 ❄️ flaky test(s)
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 To view more test analytics, go to the Test Analytics Dashboard  | 
    
d86a32a    to
    cebad4c      
    Compare
  
    2ce7329    to
    9bdb532      
    Compare
  
    369e90f    to
    063a9f4      
    Compare
  
    063a9f4    to
    296881d      
    Compare
  
    | } else { | ||
| assert.strictEqual(res.data.Versions.length, 0); | ||
| if (testResult && typeof testResult === 'object' && testResult.code) { | ||
| // This was expected to be an error, but we got success | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // This was expected to be an error, but we got success | 
| } | ||
| return s3Client.deleteBucket({ Bucket: bucketName }, done); | ||
| }); | ||
| s3Client.send(new CreateBucketCommand({ Bucket: bucketName })) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you can do convert to async/await
| DeleteObjectsCommand, | ||
| } = require('@aws-sdk/client-s3'); | ||
| const s3Client = require('./utils/s3SDK'); | ||
| 
               | 
          
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: CLDSRV-724