fix: Amplitude session_id fix #1104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 27, 2025 19:30
- added unit test cases - refactored plugin code to be in sync with swift code
wenxi-zeng
requested changes
Oct 28, 2025
There was a problem hiding this comment.
implementation mostly correct, but missing saveSessionData on a few places. probably cleaner to do the following:
- write a function (or make a property) for
eventSessionId. every time it is updated, update it to storage. you only want to updateeventSessionIdto storage. - write a function (or make a property) for
lastEventTime. every time it is updated, update it to storage. you only want to updatelastEventTimeto storage. - you no longer need
saveSessionDataonce you did 1 & 2
…Event_Time to automatic update to storage - Added new properties - Modified persistent test cases
wenxi-zeng
approved these changes
Oct 29, 2025
| this.lastEventTime = -1; | ||
| await AsyncStorage.removeItem(SESSION_ID_KEY); | ||
| await AsyncStorage.removeItem(LAST_EVENT_TIME_KEY); | ||
| await AsyncStorage.multiRemove([ |
There was a problem hiding this comment.
nit: only need to remove sessionId, since eventSessionId and lastEventTime are set to -1 by the setter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.