-
Notifications
You must be signed in to change notification settings - Fork 68
feat(front): add listing mode to workflow queries and UI #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new "listing mode" feature to the workflow queries and UI, allowing users to switch between different workflow display modes: all pipelines, all by me, and latest per branch. The feature is controlled by a feature flag (project_page_all_pipelines) and updates both the backend query logic and frontend UI components.
Key Changes:
- Added
list_modeparameter to workflow queries with support for "all_pipelines" and "latest" modes - Introduced new UI dropdown to select between workflow listing modes
- Updated cache keys to include the list_mode parameter
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| front/lib/front/project_page/model.ex | Core logic for list_mode support, including new keyset-based workflow listing and cache key updates |
| front/lib/front_web/controllers/project_controller.ex | Controller changes to handle list_mode parameter and feature flag checks |
| front/lib/front_web/templates/project/_tabs.html.eex | Added listing_requester dropdown UI for private project view |
| front/lib/front_web/templates/project/public/_tabs.html.eex | Added listing_requester dropdown UI for public project view |
| front/lib/front_web/templates/project/private.html.eex | Updated template rendering to pass new listing parameters |
| front/lib/front_web/templates/project/public.html.eex | Updated template rendering to pass new listing parameters |
| front/lib/front/memory_cookie.ex | Added projectListing cookie default value |
| front/assets/js/memory_cookie.js | Updated cookie defaults for projectListing and projectRequester |
| front/assets/js/project/components/choose_select.js | Added JavaScript logic to handle listing_requester selection changes |
| front/assets/js/workflow_list.js | Added listing and requester to query parameters |
| front/test/front/project_page/model_test.exs | Updated test to include list_mode in cache key assertion |
| front/test/front/project_page/cache_invalidator_test.exs | Updated cache key assertions to include list_mode parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
📝 Description
✅ Checklist