Skip to content

Fix escape character lookup for solidus while preserving the current behavior #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −1
Open

Fix escape character lookup for solidus while preserving the current behavior #1293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc4f1b8
Fix missing escape character lookup for forward slash (solidus).
patrickcjh Oct 15, 2025
c4e2b4e
Preserve the default behavior of not escaping solidus.
patrickcjh Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1794,6 +1794,7 @@ pub trait Formatter {
];
writer.write_all(bytes)
}
Solidus => writer.write_all(&[escape_char]),
_ => writer.write_all(&[b'\\', escape_char]),
}
}
Expand Down Expand Up @@ -2115,6 +2116,7 @@ where
self::FF => CharEscape::FormFeed,
self::RR => CharEscape::CarriageReturn,
self::QU => CharEscape::Quote,
self::FS => CharEscape::Solidus,
self::BS => CharEscape::ReverseSolidus,
self::UU => CharEscape::AsciiControl(byte),
// Safety: the escape table does not contain any other type of character.
Expand All @@ -2138,6 +2140,7 @@ const NN: u8 = b'n'; // \x0A
const FF: u8 = b'f'; // \x0C
const RR: u8 = b'r'; // \x0D
const QU: u8 = b'"'; // \x22
const FS: u8 = b'/'; // \x2F
const BS: u8 = b'\\'; // \x5C
const UU: u8 = b'u'; // \x00...\x1F except the ones above
const __: u8 = 0;
Expand All @@ -2148,7 +2151,7 @@ static ESCAPE: [u8; 256] = [
// 1 2 3 4 5 6 7 8 9 A B C D E F
UU, UU, UU, UU, UU, UU, UU, UU, BB, TT, NN, UU, FF, RR, UU, UU, // 0
UU, UU, UU, UU, UU, UU, UU, UU, UU, UU, UU, UU, UU, UU, UU, UU, // 1
__, __, QU, __, __, __, __, __, __, __, __, __, __, __, __, __, // 2
__, __, QU, __, __, __, __, __, __, __, __, __, __, __, __, FS, // 2
__, __, __, __, __, __, __, __, __, __, __, __, __, __, __, __, // 3
__, __, __, __, __, __, __, __, __, __, __, __, __, __, __, __, // 4
__, __, __, __, __, __, __, __, __, __, __, __, BS, __, __, __, // 5
Expand Down