Skip to content

Fix is_ident_start signature to take immutable reference #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

Fix is_ident_start signature to take immutable reference #409

merged 1 commit into from
Oct 24, 2025

Conversation

@nnabeyang
Copy link
Contributor

@nnabeyang nnabeyang commented Sep 28, 2025

This PR changes the signature of is_ident_start to accept &Tokenizer instead of &mut Tokenizer, since it does not need mutable access.

@mrobinson mrobinson enabled auto-merge September 30, 2025 10:31
emilio
emilio approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrobinson mrobinson added this pull request to the merge queue Oct 24, 2025
Merged via the queue into servo:main with commit 03f982e Oct 24, 2025
15 checks passed
@nnabeyang nnabeyang deleted the fix/tokenizer-is_ident_start-signature branch October 25, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilio emilio emilio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nnabeyang @emilio @mrobinson