Integrate session protocol APIs from libsession-util #1668
+2,340
−1,087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/java/org/session/libsession/messaging/sending_receiving/pollers/Poller.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/session/libsession/messaging/sending_receiving/pollers/Poller.kt
Outdated
Show resolved
Hide resolved
|
|
||
| namespace == Namespace.DEFAULT() || pushData?.metadata == null -> { | ||
| if (pushData?.data == null) { | ||
| if (pushData?.data == null || pushData.metadata?.msg_hash == null) { |
Collaborator
There was a problem hiding this comment.
Double check that call notifications aren't affected
app/src/main/java/org/session/libsession/messaging/sending_receiving/MessageParser.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
MessageSenderto useSessionProtocolto encrypt/encode messages. Also getting rid of the legacy group handling in there, and make theMessageSendera dependency injected objectMessageParserandReceivedMessageProcessorto handle different scenarios of messaging parsing and processing. Most of the logic insideReceivedMessageProcessoris copied from existing code. The existing code is there so theBatchMessageReceiverJobcan function for this time being, it will be removed in next releaseReceivedMessageHashDatabaseto replace the dodgy table we have atm. This one is used for message de-duplication and provides atomic solution for de-duplicating message.TODO
Receiving blinded messages: we are waiting for implementation from libsession-util so for now it'll error out upon receiving any of them.