Skip to content

Conversation

@pranav767
Copy link

Pull Request

What? (description)

Issue URL : #12070
This PR implements support for running the Talos dashboard on a custom console device by adding a new kernel parameter talos.dashboard.console.

Why? (reasoning)

  • Headless systems need serial console access instead of virtual terminals.
  • Remote management via serial consoles for out-of-band access.
  • Before there was automatic system change for available tty, but we can set this to a fixed tty using this kernel param.

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

@github-project-automation github-project-automation bot moved this to To Do in Planning Oct 27, 2025
@talos-bot talos-bot moved this from To Do to In Review in Planning Oct 27, 2025
@pranav767 pranav767 force-pushed the feat/dashboard-console-parameter branch from 2f72701 to ca02d47 Compare October 27, 2025 16:07
Signed-off-by: Pranav <pranavppatil767@gmail.com>
@pranav767 pranav767 force-pushed the feat/dashboard-console-parameter branch from dfd24bc to 97aca0b Compare October 27, 2025 16:16

// getCustomConsole returns the custom console parameter value if specified, empty string otherwise.
func (d *Dashboard) getCustomConsole() string {
consoleParam := procfs.ProcCmdline().Get(constants.KernelParamDashboardConsole).First()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good to me thanks, please run make lint-go, there are some small linting issues

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 👍

@smira smira self-assigned this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants