Skip to content

fix: when there is no data in the table, the primary key is not copied #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: when there is no data in the table, the primary key is not copied #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db_to_sqlite/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def cli(
except NotImplementedError:
column_type = str
create_columns[column["name"]] = column_type
db[table].create(create_columns)
db[table].create(create_columns, pks)
else:
rows = itertools.chain([first], rows)
if progress:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_db_to_sqlite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def test_db_to_sqlite(connection, tmpdir, cli_runner):
assert [{"id": 1, "name": "Lila"}] == list(db["user"].rows)
assert (
db["empty_table"].schema
== "CREATE TABLE [empty_table] (\n [id] INTEGER,\n [name] TEXT,\n [ip] TEXT\n)"
== "CREATE TABLE [empty_table] (\n [id] INTEGER PRIMARY KEY,\n [name] TEXT,\n [ip] TEXT\n)"
)
# Check foreign keys
assert [
Expand Down