Skip to content

Conversation

@poneciak57
Copy link
Contributor

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

  • created expo example app to showcase and test how audio api works in expo projects

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

"resizeMode": "contain",
"backgroundColor": "#ffffff"
},
"ios": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add audio api expo plugin, as an example usage if anyone clones it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

"react": "*",
"react-native": "*"
},
"dependencies": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary? it was done just like that in order to bump up packages only in one place. maybe we can leave all packages that have a common version for both expo and fabric?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can try to revert that particular thing but some random packages were problematic in this setup so i removed all of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants