Skip to content

Add test to verify database parameter is propagated to Predis #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add test to verify database parameter is propagated to Predis #208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ce052e
Add test to verify database parameter is propagated to Predis
pauortegathoughtworks Jun 8, 2023
2539519
Merge branch 'develop' into verify-database-parameter-is-propagated-t…
pauortegathoughtworks Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions tests/Suite/Sdk/SdkClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,56 @@ public function testGetTreatmentsFetchesSplitsInOneCall()
$client->getTreatments('key1', array('split1', 'split2', 'split3'));
}

public function testDatabaseParameterIsPropagatedToPredisClient() {
$database = 1;

Di::set(Di::KEY_FACTORY_TRACKER, false);

$parameters = array(
'scheme' => 'redis',
'host' => REDIS_HOST,
'port' => REDIS_PORT,
'timeout' => 881,
'database' => $database
);
$options = array('prefix' => TEST_PREFIX);

$sdkConfig = array(
'log' => array('adapter' => 'stdout'),
'cache' => array('adapter' => 'predis', 'parameters' => $parameters, 'options' => $options)
);

//Initializing the SDK instance.
$splitFactory = \SplitIO\Sdk::factory('asdqwe123456', $sdkConfig);
$splitSdk = $splitFactory->client();

//Storing the split in Redis in a non-default database
$predis = new \Predis\Client([
'host' => REDIS_HOST,
'port' => REDIS_PORT,
'database' => $database,
], ['prefix' => TEST_PREFIX]);

$split = [
"orgId" => null,
"environment" => null,
"trafficTypeId" => null,
"trafficTypeName" => null,
"name" => "simple-split",
"seed" => -1222652054,
"status" => "ACTIVE",
"killed" => false,
"defaultTreatment" => "on",
"conditions" => []
];
$splitName = $split['name'];
$predis->set("SPLITIO.split." . $splitName, json_encode($split));
$predis->set("SPLITIO.splits.till", 1457726098069);

//Asserting we can read the split even in a different database
$this->assertEquals('on', $splitSdk->getTreatment('user1', $splitName));
}

public static function tearDownAfterClass(): void
{
Utils\Utils::cleanCache();
Expand Down