- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2k
Add bedrock profile autoconfiguration support and replace deprecated #4742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add bedrock profile autoconfiguration support and replace deprecated #4742
Conversation
Signed-off-by: Baojun Jiang <jiangbaojun1001@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jiangbaojun,
Thanks for your contribution!
Could you please update this PR with related tests (likely in BedrockAwsConnectionConfigurationIT) and documentation changes?
| return providerBuilder.profileName(profile.getName()).build(); | ||
| } | ||
| // IAM Role | ||
| return DefaultCredentialsProvider.builder().build(); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use an else branch to make it clear that this is the 3rd exclusive case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will update later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ericbottard,
I had added tests and updated the documentation
Signed-off-by: Baojun Jiang <jiangbaojun1001@163.com>
…k_connection_config
Signed-off-by: Baojun Jiang <jiangbaojun1001@163.com>
@tzolov Update autoconfiguration, meets the requirements of three connection methods: security key, profile, and IAM Role
DefaultCredentialsProvider.create()was deprecated, replace withDefaultCredentialsProvider.builder().build()example configuration