Make PapaSafeTrace isTraceable configurable #1428
Open
+27
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change PapaSafeTrace from delegating to SafeTrace.isTraceable to accepting isTraceable as a constructor parameter. This gives clients direct control over whether tracing is enabled, removing the implicit dependency on SafeTrace.isTraceable, which will be removed soon. Update WorkflowPapaTracer's default to explicitly pass isTraceable=false to avoid overhead. Add tests to verify the new configuration capability for both PapaSafeTrace and WorkflowPapaTracer.
tcmulcahy
force-pushed
the
tomm/remove-safe-trace-is-traceable
branch
from
db57be0 to
b8c78b8
Compare
tcmulcahy
commented
Nov 7, 2025
| public final class com/squareup/workflow1/tracing/papa/PapaSafeTrace : com/squareup/workflow1/tracing/SafeTraceInterface { | ||
| public fun <init> ()V | ||
| public fun <init> (Z)V | ||
| public synthetic fun <init> (ZILkotlin/jvm/internal/DefaultConstructorMarker;)V |
Collaborator
Author
There was a problem hiding this comment.
Kotlin generates this when you have parameters with default values - see https://stackoverflow.com/a/53912965 for details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change PapaSafeTrace from delegating to SafeTrace.isTraceable to accepting isTraceable as a constructor parameter. This gives clients direct control over whether tracing is enabled, removing the implicit dependency on SafeTrace.isTraceable, which will be removed soon.
Update WorkflowPapaTracer's default to explicitly pass isTraceable=false to avoid overhead. Add tests to verify the new configuration capability for both PapaSafeTrace and WorkflowPapaTracer.