Remove on exit

[matdodgson]

Hi Steve! Thanks for making such an excellent project.

We have been encountering an issue with git-js in our environment. Our Salesforce team is using git-js through another package sfdx-git-delta which is a git based diff tool for packaging Salesforce projects.

The issue we're encountering is that occasionally, under heavy and concurrent load, SGD receives an incomplete file from git-js. This is due to the fact that git-js listens to the exit event and will return early from the git show command thereby chopping off the end of the file.

This PR removes the exit listener altogether and that fixes our issue. I see in the completion plugin docs that you were planning on turning off the exit listener at some point but maybe decided not to. Are you happy with the idea of removing the exit listener altogether? Nodejs docs say close happens after exit and that it happens after stdout & stderr are closed.

[changeset-bot]

⚠️ No Changeset found

Latest commit: d562af9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR