Skip to content

Adding L431RC Generic #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2022
Merged

Adding L431RC Generic #1736

merged 1 commit into from
Jun 21, 2022

Conversation

@mackelec
Copy link
Contributor

@mackelec mackelec commented Jun 3, 2022

Adding L431RC generic.
Added ldscript.ld
Edited Boards and Readme

@fpistm fpistm requested a review from ABOSTM June 6, 2022 07:44
@fpistm fpistm added the new variant Add support of new bard label Jun 6, 2022
ABOSTM
ABOSTM suggested changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mackelec for this Pull Request.
It would be great if you could also update the generic clock so that users can benefit from 80Mhz (thanks to PLL), instead of relying on default 4Mhz clock (MSI).
https://github.com/stm32duino/wiki/wiki/Add-a-new-variant-%28board%29#3---generic-system-clock-configuration

@mackelec
Copy link
Contributor Author

mackelec commented Jun 7, 2022

Thank you for your review. I hope I've made all the correct updates this time.

ABOSTM
ABOSTM suggested changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mackelec,
Thanks for this update,
It looks like you kind of revert several merged commit.
I did not list all but there is clearly too much update in board.txt

ABOSTM
ABOSTM suggested changes Jun 7, 2022
View reviewed changes
ABOSTM
ABOSTM suggested changes Jun 8, 2022
View reviewed changes
fpistm
fpistm reviewed Jun 16, 2022
View reviewed changes
@ABOSTM ABOSTM force-pushed the main branch 2 times, most recently from c73c1cb to 3795162 Compare June 16, 2022 14:48
@ABOSTM
Copy link
Contributor

ABOSTM commented Jun 16, 2022

Hi @mackelec ,
I updated your Pull Request to:

  • add all STM32L431Rx MCU as they share the same linker script and the same generic clock file
  • run astyle
  • squash the whole as a single commit

@ABOSTM ABOSTM requested a review from fpistm June 16, 2022 14:52
fpistm
fpistm requested changes Jun 21, 2022
View reviewed changes
@ABOSTM
feat: add support of generic variant STM32L431Rx
45eec60 
Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
fpistm
fpistm approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mackelec & @ABOSTM

@fpistm fpistm merged commit ab95f98 into stm32duino:main Jun 21, 2022
cparata pushed a commit to cparata/Arduino_Core_STM32 that referenced this pull request Jan 31, 2023
@mackelec @ABOSTM @cparata
feat: add support of generic variant STM32L431Rx (stm32duino#1736)
c5d5cff 
Co-authored-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpistm fpistm fpistm approved these changes

+1 more reviewer

@ABOSTM ABOSTM ABOSTM requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new variant Add support of new bard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mackelec @ABOSTM @fpistm