Skip to content

Conversation

@jeetburman
Copy link

Implements visual bar lines in Phrase Maker widget that reflect meter block settings.

Changes:

  • Detects current meter from turtle singer state
  • Calculates bar positions based on beats per measure
  • Applies thick border styling to show measure boundaries
  • Supports all time signatures (4/4, 3/4, 6/8, etc.)

Fixes #4737

Before :
Screenshot 2025-09-20 231722

After :
Screenshot 2025-09-20 231636

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@walterbender
Copy link
Member

I like what you are trying to do. But I think you may be tagging beats rather than measures. That is what it looks like in the screenshot you shared.

@jeetburman
Copy link
Author

Thank you for responding Walter. I will make the necessary tweaks asap.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@jeetburman
Copy link
Author

jeetburman commented Sep 23, 2025

Hello @walterbender , I did the needful changes. Pls review.
Now the measures are being tagged instead of beats
Screenshot 2025-09-23 110527

@walterbender
Copy link
Member

I think you have this hardwired to 4/4.

Screenshot From 2025-09-23 09-23-25

@jeetburman
Copy link
Author

@walterbender , apologies for prolonging this. I will make it flexible to other variations as well, not just for 4/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bar lines for Phrase Maker specified by meter block

2 participants