Skip to content

Added Hindi Translation Support (.po) #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Added Hindi Translation Support (.po) #4772

wants to merge 14 commits into from

Conversation

@ac-mmi
Copy link
Contributor

@ac-mmi ac-mmi commented Oct 7, 2025

Added a .po file to provide Hindi localization support for Music Blocks, enabling the interface to be displayed in Hindi . This enhances accessibility for speakers of Hindi and contributes to internationalization efforts.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

suryaanshah
suryaanshah suggested changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@suryaanshah suryaanshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the file’s formatting has changed, resulting in a large diff even though the actual edits are minimal. Please revert the formatting changes and submit a clean diff with only the intended modifications.

suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
locales/hi.json
"Equal (7EDO)": "समान (7EDO)",
"Equal (19EDO)": "समान (19EDO)",
"Equal (31EDO)": "समान (31EDO)",
"5-limit Just Intonation": "5-सीमा सही स्वर ताल",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be translated as:

Suggested change
"5-limit Just Intonation": "5-सीमा सही स्वर ताल",
"5-limit Just Intonation": "केवल स्वर ताल को बाधित करें",

suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
suryaanshah
suryaanshah reviewed Oct 17, 2025
View reviewed changes
@ac-mmi @suryaanshah
Update locales/hi.json
6841a76 
Co-authored-by: Suryaansh Chawla <suryaanshchawla@tutamail.com>
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

ac-mmi and others added 2 commits October 17, 2025 12:40
@ac-mmi @suryaanshah
Update locales/hi.json
c090b90 
Co-authored-by: Suryaansh Chawla <suryaanshchawla@tutamail.com>
@ac-mmi @suryaanshah
Update locales/hi.json
25ee825 
Co-authored-by: Suryaansh Chawla <suryaanshchawla@tutamail.com>
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

1 similar comment
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

1 similar comment
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

1 similar comment
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

1 similar comment
@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@suryaanshah
Copy link
Contributor

@pikurasa
I’ve verified that:

  1. No existing translations were modified or re-translated — i.e., there are no regressions in previously translated text.
  2. The only remaining issue is ordering/formatting — the new translations should be added without reshuffling the entire file (to avoid a 25k-line diff).

Would adding the previously untranslated text as new lines (at the bottom of the file) be acceptable?
If yes, could you please take care of that, @ac-mmi?

@ac-mmi
Copy link
Contributor Author

ac-mmi commented Oct 25, 2025

@suryaanshah I am using the updated POT file, which has resulted in a different order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@suryaanshah suryaanshah suryaanshah requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ac-mmi @suryaanshah