feat: vector buckets #774
feat: vector buckets #774
Conversation
⛔ Snyk checks have failed. 8 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![snyk-io[bot]](https://avatars.githubusercontent.com/in/372950?s=60&v=4){kind=small}
fenos
force-pushed
the
feat/vector-buckets
branch
6 times, most recently
from
01797cc to
a2715e7
Compare
Pull Request Test Coverage Report for Build 18909481244Details
💛 - Coveralls |
src/app.ts
Outdated
| app.register(routes.cdn, { prefix: 'cdn' }) | ||
| app.register(routes.healthcheck, { prefix: 'health' }) | ||
| app.register(routes.iceberg, { prefix: 'iceberg/v1' }) | ||
| app.register(routes.vectors, { prefix: 'vectors' }) |
There was a problem hiding this comment.
should this be singular ("vector")? to match: bucket, object, ...
src/http/error-handler.ts
Outdated
| : 400 | ||
|
|
||
| if (statusCode === 500) { | ||
| console.log('error') |
| } | ||
| } | ||
|
|
||
| throw ERRORS.TransactionError('Transaction failed after maximum retries', lastError) |
There was a problem hiding this comment.
Might be nice to make "after maximum retries" conditional on if there were retires, and/or maybe include the retry count in the error message to avoid confusion if we need to debug this in the future.
There was a problem hiding this comment.
Not sure i understood this, but in isolation mode: 'serialize' retrying the transaction is a common pattern
if the max retries are reached means that there are too many concurrent operations, which makes this transaction fail
There was a problem hiding this comment.
I just meant adding the count to the error message or only saying "after maximum retries" if there were retries as currently it says that even for requests that had no retries.
fenos
force-pushed
the
feat/vector-buckets
branch
from
a2715e7 to
6bf5f59
Compare
fenos
force-pushed
the
feat/vector-buckets
branch
from
6bf5f59 to
f2ae953
Compare
| search: query.search, | ||
| }) | ||
|
|
||
| return response.status(200).send(bucket) |
There was a problem hiding this comment.
Cross-site Scripting (XSS)
Unsanitized input from an HTTP parameter flows into send, where it is used to render an HTML page returned to the user. This may result in a Cross-Site Scripting attack (XSS).
Line 119 | CWE-79 | Priority score 848 | Learn more about this vulnerability
Data flow: 14 steps
Step 1 - 3
storage/src/http/routes/iceberg/bucket.ts
Line 109 in f2ae953
Step 4 - 7 src/http/routes/iceberg/bucket.ts#L112
Step 8 - 12 src/http/routes/iceberg/bucket.ts#L111
Step 13 - 14
storage/src/http/routes/iceberg/bucket.ts
Line 119 in f2ae953
fenos
force-pushed
the
feat/vector-buckets
branch
from
02f1ec8 to
ee74d2a
Compare
fenos
force-pushed
the
feat/vector-buckets
branch
from
ee74d2a to
111c2b2
Compare
What kind of change does this PR introduce?
Feature
What is the new behaviour?
Implement Vector Bucket data source
Supported Operations:
Authentication mechanisms: