-
-
Couldn't load subscription status.
- Fork 375
feat(auth): add OAuth 2.1 client admin endpoints #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grdsdev
wants to merge
7
commits into
main
Choose a base branch
from
feat/auth-oauth-client-admin-endpoints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f42ebc0
feat(auth): add OAuth 2.1 client admin endpoints
grdsdev b48c6ff
fix(auth): handle empty responses and OAuth client list parsing
grdsdev d81c379
chore(auth): upgrade GoTrue to v2.180.0 and enable OAuth server
grdsdev 64f464e
fix: validate id as uuid
grdsdev 8ff32ea
fix: use BaseModel instead of TypedDict
grdsdev 4b66979
fix: update OAuthClient type with latest changes
grdsdev db6d4f6
fix: add missing uuid validations
grdsdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
src/auth/src/supabase_auth/_async/gotrue_admin_oauth_api.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| from ..types import ( | ||
| CreateOAuthClientParams, | ||
| OAuthClientListResponse, | ||
| OAuthClientResponse, | ||
| PageParams, | ||
| ) | ||
|
|
||
|
|
||
| class AsyncGoTrueAdminOAuthAPI: | ||
| """ | ||
| Contains all OAuth client administration methods. | ||
| Only relevant when the OAuth 2.1 server is enabled in Supabase Auth. | ||
| """ | ||
|
|
||
| async def list_clients( | ||
| self, | ||
| params: PageParams | None = None, | ||
| ) -> OAuthClientListResponse: | ||
| """ | ||
| Lists all OAuth clients with optional pagination. | ||
| Only relevant when the OAuth 2.1 server is enabled in Supabase Auth. | ||
|
|
||
| This function should only be called on a server. | ||
| Never expose your `service_role` key in the browser. | ||
| """ | ||
| raise NotImplementedError() # pragma: no cover | ||
|
|
||
| async def create_client( | ||
| self, | ||
| params: CreateOAuthClientParams, | ||
| ) -> OAuthClientResponse: | ||
| """ | ||
| Creates a new OAuth client. | ||
| Only relevant when the OAuth 2.1 server is enabled in Supabase Auth. | ||
|
|
||
| This function should only be called on a server. | ||
| Never expose your `service_role` key in the browser. | ||
| """ | ||
| raise NotImplementedError() # pragma: no cover | ||
|
|
||
| async def get_client( | ||
| self, | ||
| client_id: str, | ||
| ) -> OAuthClientResponse: | ||
| """ | ||
| Gets details of a specific OAuth client. | ||
| Only relevant when the OAuth 2.1 server is enabled in Supabase Auth. | ||
|
|
||
| This function should only be called on a server. | ||
| Never expose your `service_role` key in the browser. | ||
| """ | ||
| raise NotImplementedError() # pragma: no cover | ||
|
|
||
| async def delete_client( | ||
| self, | ||
| client_id: str, | ||
| ) -> OAuthClientResponse: | ||
| """ | ||
| Deletes an OAuth client. | ||
| Only relevant when the OAuth 2.1 server is enabled in Supabase Auth. | ||
|
|
||
| This function should only be called on a server. | ||
| Never expose your `service_role` key in the browser. | ||
| """ | ||
| raise NotImplementedError() # pragma: no cover | ||
|
|
||
| async def regenerate_client_secret( | ||
| self, | ||
| client_id: str, | ||
| ) -> OAuthClientResponse: | ||
| """ | ||
| Regenerates the secret for an OAuth client. | ||
| Only relevant when the OAuth 2.1 server is enabled in Supabase Auth. | ||
|
|
||
| This function should only be called on a server. | ||
| Never expose your `service_role` key in the browser. | ||
| """ | ||
| raise NotImplementedError() # pragma: no cover |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@o-santi I'm using this uuid validation because it was already what was being used by other methods.
Since this is a new feature, does it make sense for the
client_idparam to be of typeuuid.UUIDinstead of a rawstr? So we don't need to validate it? We do this in Swift, but I don't know about Python.