Add a snooze option for port discovery #100
Conversation
src/tailscale/cli.ts
Outdated
|
|
||
| async snooze() { | ||
| this.snoozing = true; | ||
| setTimeout(() => { |
There was a problem hiding this comment.
This is only going to snooze for 15 minutes within the instance of VS Code it was triggered in. I would like a prompt for the duration, including day, week, and month. For this, I am thinking we could use context.globalStoragePath and persist the port config (snooze info) to disk.
Thoughts @samlinville @christine-tailscale
There was a problem hiding this comment.
When does this notification show up? Will the snooze function delay just this message or will it snooze all notifications from us?
I'm assuming that users would want to snooze because they're in the middle of something else and want to save it for later. What if instead of offering them custom snooze options, we offer them a quick yes/no decision? And then if they click no, we can use that notification to educate them where port discovery lives if they want to come back to it later?
There was a problem hiding this comment.
The notification shows up as part of port discovery and as this PR stands snoozes discovery entirely:
There was a problem hiding this comment.
We should persist in the requested snooze duration (storing the time when we can unsnooze). We should not offer a calendar or complex form to fill out (we're trying to work around an annoyance, let's not annoy them more). Let's keep it simple.
15 minutes seems too short, TBH. The goal is to provide a reasonable snooze option that keeps the port disco from annoying users. If snooze is too short, we're still annoying them. The minimum risk is that the person will disable port disco notifications altogether. The max is the uninstall.
I wouldn't oppose a single "Snooze for 1hr" or "Snooze" and then prompting with 1 hour, 2 hours, or this session. (For example)
|
Is this the right place for copy feedback? Wondering if we can update the toast notification to use active voice. Update |
|
@christine-tailscale of course, all places are accepting of copy feedback! |
tylersmalley
force-pushed
the
marwan/snooze
branch
3 times, most recently
from
163a7a8 to
5a4e837
Compare
tylersmalley
force-pushed
the
marwan/snooze
branch
from
5a4e837 to
6b1d651
Compare
src/tailscale/cli.ts
Outdated
| this.snoozing = true; | ||
| setTimeout(() => { | ||
| this.snoozing = false; | ||
| }, 900000); // fifteen minutes |
There was a problem hiding this comment.
prefer const snoozeDuration = 15 * 60 * 1000 then reference the const.
Signed-off-by: Naman Sood <mail@nsood.in>
Signed-off-by: Naman Sood <mail@nsood.in>
Signed-off-by: Naman Sood <mail@nsood.in>
This PR is a follow up on #94 and adds a snooze option with a message to let users know about the available on/off settings.
Updates #80
Feel free to suggest a different copy/UX.