serve/simple: Use message passing instead of HTTP #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
changed the title
tylersmalley
changed the title
tylersmalley
force-pushed
the
tyler/messages
branch
3 times, most recently
from
d2c8fdf to
2f3846d
Compare
tylersmalley
force-pushed
the
tyler/messages
branch
4 times, most recently
from
17bfc94 to
47b3d50
Compare
tylersmalley
force-pushed
the
tyler/messages
branch
3 times, most recently
from
7bc06e7 to
15a5808
Compare
Implements a frameworks to support asynchronous requests using messages. Signed-off-by: Tyler Smalley <tyler@tailscale.com>
tylersmalley
force-pushed
the
tyler/messages
branch
from
15a5808 to
17ee931
Compare
tylersmalley
added a commit
that referenced
this pull request
Jul 20, 2023
We were not using this test infrastructure, and after #56 it should be better to accomplish these tests using something like playwright. @vscode/test-electron is really not ideal. It's heavy, and does not provide any tooling to test webviews, which we make use of. Signed-off-by: Tyler Smalley <tyler@tailscale.com>
tylersmalley
added a commit
that referenced
this pull request
Jul 20, 2023
We were not using this test infrastructure, and after #56 it should be better to accomplish these tests using something like playwright. @vscode/test-electron is really not ideal. It's heavy, and does not provide any tooling to test webviews, which we make use of. --------- Signed-off-by: Tyler Smalley <tyler@tailscale.com>
tylersmalley
added a commit
that referenced
this pull request
Jul 20, 2023
We were not using this test infrastructure, and after #56 it should be better to accomplish these tests using something like playwright. @vscode/test-electron is really not ideal. It's heavy, and does not provide any tooling to test webviews, which we make use of. Signed-off-by: Tyler Smalley <tyler@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a framework to support asynchronous requests using messages.
Part of #36
TODO:
isMutatingis not being set.