feat: added support for msgspec schemas now called Schema along with refactoring volutpous schemas to now be called LegacySchema #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactoring volutpous schemas to now be called LegacySchema
abhishekmadan30
force-pushed
the
schema-support
branch
from
b836118 to
e9b2333
Compare
|
I see this is failing the free-threading tests; I think that's probably fine - it's not officially supported here yet. AFAICT, free-threading is supported in the unreleased version of msgspec, and they expect to release soon, so we can pick it up when they do. |
bhearsum
added a commit
to bhearsum/taskgraph
that referenced
this pull request
Oct 29, 2025
Over in taskcluster#844, free-threaded python tests are causing `complete-pr` not to run because `msgspec` hasn't released a version that supports it yet. This highlights the fact that free-threading is not officially supported in Taskgraph yet, so we shouldn't block other tasks on these tests.
bhearsum
added a commit
to bhearsum/taskgraph
that referenced
this pull request
Oct 30, 2025
Over in taskcluster#844, free-threaded python tests are causing `complete-pr` not to run because `msgspec` hasn't released a version that supports it yet. This highlights the fact that free-threading is not officially supported in Taskgraph yet, so we shouldn't block other tasks on these tests.
bhearsum
added a commit
that referenced
this pull request
Oct 30, 2025
Over in #844, free-threaded python tests are causing `complete-pr` not to run because `msgspec` hasn't released a version that supports it yet. This highlights the fact that free-threading is not officially supported in Taskgraph yet, so we shouldn't block other tasks on these tests.
ahal
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Per https://www.conventionalcommits.org/en/v1.0.0/, please make the prefix feat!: to denote that it's a breaking change. I'd also make the summary shorter, and include the extra context about LegacySchema in a new paragraph.
If you could also update docs/reference/migrations.rst with how to deal with the backwards incompatibility, that would be appreciated! Just make a new 18.x section
ahal
added
the
BREAKING CHANGE
bhearsum
added a commit
to bhearsum/taskgraph
that referenced
this pull request
Oct 31, 2025
Over in taskcluster#844, free-threaded python tests are causing `complete-pr` not to run because `msgspec` hasn't released a version that supports it yet. This highlights the fact that free-threading is not officially supported in Taskgraph yet, so we shouldn't block other tasks on these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.