Skip to content

fix clean up integrity check error from zui #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

fix clean up integrity check error from zui #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions cmds/modules/provisiond/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ var Module cli.Command = cli.Command{
// state
func integrityChecks(ctx context.Context, rootDir string) error {
err := ReportChecks(filepath.Join(rootDir, metricsStorageDB))

if err != nil {
fmt.Fprintln(os.Stderr, err)
}
Expand All @@ -101,17 +100,22 @@ func runChecks(ctx context.Context, rootDir string, cl zbus.Client) error {
var buf bytes.Buffer
cmd.Stderr = &buf

zui := stubs.NewZUIStub(cl)
// empty out zui errors for registrar
if zuiErr := zui.PushErrors(ctx, "integrity", []string{}); zuiErr != nil {
log.Info().Err(zuiErr).Send()
}

cmd.CombinedOutput()
err := cmd.Run()
if err == context.Canceled {
if errors.Is(err, context.Canceled) {
return err
} else if err == nil {
return nil
}

log.Error().Str("stderr", buf.String()).Err(err).Msg("integrity check failed, resetting rrd db")

zui := stubs.NewZUIStub(cl)
if er := zui.PushErrors(ctx, "integrity", []string{
fmt.Sprintf("integrity check failed, resetting rrd db stderr=%s: %v", buf.String(), err),
}); er != nil {
Expand Down Expand Up @@ -181,7 +185,7 @@ func action(cli *cli.Context) error {

// the v1 endpoint will be used by all components to register endpoints
// that are specific for that component
//v1 := router.PathPrefix("/api/v1").Subrouter()
// v1 := router.PathPrefix("/api/v1").Subrouter()
// keep track of resource units reserved and amount of workloads provisionned

// to store reservation locally on the node
Expand Down Expand Up @@ -313,7 +317,7 @@ func action(cli *cli.Context) error {
zos.PublicIPv4Type,
zos.PublicIPType,
zos.ZMachineLightType,
zos.ZLogsType, //make sure zlogs comes after zmachine
zos.ZLogsType, // make sure zlogs comes after zmachine
),
// if this is a node reboot, the node needs to
// recreate all reservations. so we set rerun = true
Expand All @@ -323,7 +327,6 @@ func action(cli *cli.Context) error {
// capacity on chain.
provision.WithCallback(setter.Callback),
)

if err != nil {
return errors.Wrap(err, "failed to instantiate provision engine")
}
Expand All @@ -345,6 +348,7 @@ func action(cli *cli.Context) error {
// call the runtime upgrade before running engine
if err := provisioners.Initialize(ctx); err != nil {
log.Error().Err(err).Msg("failed to run provisioners initializers")
return err
}

// spawn the engine
Expand Down
Loading