Fix #12: Improve exception handling information in ScanTarget #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Store UnknownHostException message when host resolution fails - Track denylist reason (domain vs IP) for better diagnostics - Add helper method to determine specific denylist cause - Add getters/setters for new diagnostic fields This addresses issue #12 by retaining diagnostic information that was previously discarded, improving debugging capabilities.
Contributor
Author
|
looks good but I want to see tests |
XoMEX
requested changes
Nov 4, 2025
Comment on lines
+139
to
+141
| private String unresolvedReason; | ||
|
|
||
| private String denylistReason; |
Member
There was a problem hiding this comment.
I dislike the approach of adding error only fields to the scan target.
Member
|
I think the cleaner approach would be to wrap the caught exception into a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
unresolvedReasonfield to store exception messages when host resolution failsdenylistReasonfield to track why a target was denylisteddetermineDenylistReason()method to distinguish between domain and IP denylistingTest plan
mvn clean testmvn spotless:applyThis addresses issue #12 by retaining diagnostic information that was previously discarded, improving debugging capabilities for failed host resolutions and denylisted targets.