added support for more HTTP response headers #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change reflects the same configuratin present in tor2web.utils.ssl and applied on globaleaks in globaleaks in relation to ticket: globaleaks/globaleaks-whistleblowing-software#1182
For example, the "Link" and "X-Pingback" headers on: http://54ogum7gwxhtgiya.onion This patch makes those headers (and others) work as intended.
|
Correction, URL is: http://54ogum7gwxhtgiya.onion/blog/index.php/welcome-home/ |
1 similar comment
|
|
|
|
|
|
evilaliv3
force-pushed
the
master
branch
6 times, most recently
from
40e64bd to
5605f62
Compare
evilaliv3
force-pushed
the
master
branch
8 times, most recently
from
aabeadf to
aecb3d0
Compare
evilaliv3
force-pushed
the
master
branch
3 times, most recently
from
652cb18 to
d8a5096
Compare
evilaliv3
force-pushed
the
master
branch
2 times, most recently
from
a088782 to
de732c0
Compare
evilaliv3
force-pushed
the
master
branch
3 times, most recently
from
8077cf5 to
c45be7f
Compare
evilaliv3
force-pushed
the
master
branch
3 times, most recently
from
49963c6 to
3c31643
Compare
evilaliv3
force-pushed
the
master
branch
2 times, most recently
from
e0678e9 to
a325583
Compare
evilaliv3
force-pushed
the
master
branch
15 times, most recently
from
b1be310 to
501c22a
Compare
evilaliv3
reviewed
Jul 13, 2022
| var xmlhttp = new XMLHttpRequest(); | ||
|
|
||
| xmlhttp.onreadystatechange=function() { | ||
| if (xmlhttp.readyState==4 && xmlhttp.status==200) { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace ==4·&&·xmlhttp.status== with ·==·4·&&·xmlhttp.status·==·
Suggested change
| if (xmlhttp.readyState==4 && xmlhttp.status==200) { | |
| if (xmlhttp.readyState == 4 && xmlhttp.status == 200) { |
evilaliv3
reviewed
Jul 13, 2022
| window.location.href = url; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Codacy has a fix for the issue: Insert ;
Suggested change
| } | |
| }; |
evilaliv3
reviewed
Jul 13, 2022
| // Test if the user is using Tor and in that case | ||
| // redirects the user to provided url | ||
| try { | ||
| if (typeof(test_url) === 'undefined') { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace (test_url)·===·'undefined' with ·test_url·===·"undefined"
Suggested change
| if (typeof(test_url) === 'undefined') { | |
| if (typeof test_url === "undefined") { |
evilaliv3
reviewed
Jul 13, 2022
| // redirects the user to provided url | ||
| try { | ||
| if (typeof(test_url) === 'undefined') { | ||
| var test_url = 'https://antani.tor2web.org/checktor'; |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace 'https://antani.tor2web.org/checktor' with "https://antani.tor2web.org/checktor"
Suggested change
| var test_url = 'https://antani.tor2web.org/checktor'; | |
| var test_url = "https://antani.tor2web.org/checktor"; |
evilaliv3
reviewed
Jul 13, 2022
| if (window.XMLHttpRequest) { | ||
| var xmlhttp = new XMLHttpRequest(); | ||
|
|
||
| xmlhttp.onreadystatechange=function() { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace =function with ·=·function·
Suggested change
| xmlhttp.onreadystatechange=function() { | |
| xmlhttp.onreadystatechange = function () { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, the "Link" and "X-Pingback" headers on:
http://54ogum7gwxhtgiya.onion
This patch makes those headers (and others) work as intended.