[Documentation] Fix Security Risks #4421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update least privilege to read only for GH Actions example. Add blurb about least permission. Fix an injection attack that is possible with specially crafted PRs and commits that allows threat actors to run malicious commands in the GH Actions execution context. Update GH Action version to the latest version. Update @main reference to SHA hash place holder as @main is a risk too for execution take over, only pinned commits should be used for actions.
|
|
elliot-huffman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The documentation recommended to put insecure code into GH Actions workflows, this was lit up like a Christmas tree in CodeQL in my environment. This PR is to fix the recommended configuration so that injection/takeover attacks are not the recommended default.
Changes:
Checklist:
Readme change only, no code changes in the project.