Skip to content

Cache lookup_field result to avoid repeated evaluation in inlines #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cache lookup_field result to avoid repeated evaluation in inlines #1630

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5725ba5
inlines many sql fix
Oct 23, 2025
8046946
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 23, 2025
f29cfec
Merge branch 'unfoldadmin:main' into inlines_manysql_fix
alexxxxey Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/unfold/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ def label_tag(self) -> SafeText:

return format_html("<label{}>{}</label>", flatatt(attrs), capfirst(label))

def _lookup_field(self, field, obj, model_admin):
try:
return self._lookup_field_cached
except AttributeError:
self._lookup_field_cached = lookup_field(field, obj, model_admin)
return self._lookup_field_cached

@property
def url(self) -> str | bool:
field, obj, model_admin = (
Expand All @@ -46,7 +53,7 @@ def url(self) -> str | bool:
)

try:
f, attr, value = lookup_field(field, obj, model_admin)
f, attr, value = self._lookup_field(field, obj, model_admin)
except (AttributeError, ValueError, ObjectDoesNotExist):
return False

Expand All @@ -69,7 +76,7 @@ def is_json(self) -> bool:
)

try:
f, attr, value = lookup_field(field, obj, model_admin)
f, attr, value = self._lookup_field(field, obj, model_admin)
except (AttributeError, ValueError, ObjectDoesNotExist):
return False

Expand All @@ -83,7 +90,7 @@ def is_image(self) -> bool:
)

try:
f, attr, value = lookup_field(field, obj, model_admin)
f, attr, value = self._lookup_field(field, obj, model_admin)
except (AttributeError, ValueError, ObjectDoesNotExist):
return False

Expand All @@ -106,7 +113,7 @@ def is_file(self) -> bool:
)

try:
f, attr, value = lookup_field(field, obj, model_admin)
f, attr, value = self._lookup_field(field, obj, model_admin)
except (AttributeError, ValueError, ObjectDoesNotExist):
return False

Expand Down Expand Up @@ -142,7 +149,7 @@ def _get_contents(self) -> str:
self.model_admin,
)
try:
f, attr, value = lookup_field(field, obj, model_admin)
f, attr, value = self._lookup_field(field, obj, model_admin)
except (AttributeError, ValueError, ObjectDoesNotExist):
result_repr = self.empty_value_display
else:
Expand Down