Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Conversation

@xiaoxiangmoe
Copy link
Collaborator

@xiaoxiangmoe xiaoxiangmoe commented Feb 12, 2022

since ts 4.5, typescript will read exports field in package.json

{
  "exports": {
    ".": {
      "require": "./dist/index.js",
      "import": "./dist/index.mjs",
      "types": "./index.d.ts"
    },
    ...
  },
  ...
}

So we should keep type in root dir same as types in dist dir.

@xiaoxiangmoe xiaoxiangmoe marked this pull request as draft February 12, 2022 10:19
@xiaoxiangmoe xiaoxiangmoe changed the title feat: remove useless import shims fix: types in root dir Feb 12, 2022
@xiaoxiangmoe xiaoxiangmoe marked this pull request as ready for review February 12, 2022 10:25
@xiaoxiangmoe xiaoxiangmoe marked this pull request as draft February 12, 2022 10:49
@xiaoxiangmoe xiaoxiangmoe marked this pull request as ready for review February 12, 2022 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant